cluster-api-provider-vsphere icon indicating copy to clipboard operation
cluster-api-provider-vsphere copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Remove legacy labels and handling

Open killianmuldoon opened this issue 2 years ago • 16 comments
trafficstars

There's a number labels in the CAPV codebase related to older APIVersions that should be removed along with the code that handles transitioning them.

We have:

  • Added in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/1486 https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/653d6e9196b1a5e67003da6c5e8850dd7690dd83/controllers/vspherecluster_reconciler.go#L58

  • Added in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/1536 https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/653d6e9196b1a5e67003da6c5e8850dd7690dd83/pkg/services/network/constants.go#L37

  • Added in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/issues/1483 https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/09ff688ddb29e6a8900c1aa02241f5b26de15713/pkg/services/vmoperator/control_plane_endpoint.go#L53-L54

These PRs were all introduced in CAPV v1.2.0 https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/releases/tag/v1.2.0 and were introduced as part of the v1beta1 API.

Each of the above were introduced with the explicit legacy prefix, and none are public go variables.

v1.9.0 is 7 releases down the line from when these were introduced and I think we should consider removing them now.

killianmuldoon avatar Sep 26 '23 10:09 killianmuldoon