kennytm

Results 391 comments of kennytm

for BatchSplit to be done concurrently you need a lock per (source region ID + Epoch) to avoid retries.

Err so there is a minimal test case then?

well the issue here is that it's not logged, which should be fixed 😅

Instead of adding a `rate_limit` field to local storage only, I suggest adapting to the existing `--ratelimit` parameter. * Not good: `-o 'local:///data/output?rate_limit=100'` * Good: `--ratelimit 100 -o 'local:///data/output'` The...

@recall704 sorry for late reply, there's a week-long holiday in China and Japan 🙃. > I try to use withRatelimit to set rate limit, but I have to overwrite Create...

Hi. Currently a cronjob is the supported way to perform [PiTR](https://docs.pingcap.com/tidb/stable/use-br-command-line-tool#point-in-time-recovery-experimental-feature). A dedicated PiTR tool #325 is a long-term plan.

As of tikv/pd#3055 we can list enabled and paused schedulers. However there is no API to list all disabled schedulers, which means we gotta hard-code the built-in scheduler names. *...

This is a bug in TiDB. Still, such failure probably shouldn't abort backup/restore since stats aren't essential. also, the dump stats error should log which table is the cause. https://github.com/pingcap/br/blob/458d542b19ca8563cac4322888063476cd050c4d/pkg/backup/client.go#L348-L358