kennytm

Results 391 comments of kennytm

why not just don't generate those empty SSTs in the first place

so where did the `total_bytes = null` SSTs come from 😂

@gregwebs unfortunately as long as there is a cyclic dependency between BR and TiDB we can't avoid the `go.mod1` trick 😢 (#554).

> The issue is that I was using unistore for TiDB sorry could you clarify how the TiDB cluster is set up?

Ah I see. BR never connects to TiDB, it just decodes the data from TiKV directly. Therefore there is no connectivity issue. We can at most print a list of...

there should be a `[loader] file is filtered by file router` log entry for every skipped file. maybe we can improve the wordings.

Are we going to need a spare TiKV cluster for this? The main issue about constructing the SST file. This is similar to Lightning Local Backend which streams sorted KV...

i think we need a ```go if len(aws.StringValue(ses.Config.Region)) == 0 { ses.Config.Region = aws.String("please supply --s3.region") } ``` after line 250 to prevent that `MissingRegion` error thrown by the AWS...