br icon indicating copy to clipboard operation
br copied to clipboard

Published 20 hours ago • verified publisher icon pingcap

log_restore: refactor write and ingest logic. (#645)

Open ti-srebot opened this issue 4 years ago • 5 comments

cherry-pick #645 to release-4.0 You can switch your code base to this Pull Request by using git-extras:

# In br repo:
git pr https://github.com/pingcap/br/pull/729

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/br.git pr/729:release-4.0-d87292ca02cb

What problem does this PR solve?

Both Lightning and BR have a similar logic. write and ingest kv as well as retry policy. This abstract Ingest method for BR and Lightning easy to use.

What is changed and how it works?

  1. Refactor write and ingest code from log_client to Ingestser.

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note.

ti-srebot avatar Jan 31 '21 01:01 ti-srebot

/lgtm

kennytm avatar Feb 04 '21 02:02 kennytm

/rebuild

3pointer avatar Mar 03 '21 06:03 3pointer

/run-all-tests

glorv avatar Mar 10 '21 03:03 glorv

@ti-srebot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Jun 29 '21 20:06 ti-chi-bot

@3pointer Do we still need to cherry-pick this PR to release-4.0?

glorv avatar Jul 21 '21 02:07 glorv