kennytm

Results 392 comments of kennytm

All links are 404, the URLs should use `/issues/` not `/issue/`.

Better just move them below the "approved" PRs instead of hiding.

The same reason we show PRs which have no status.

I'm opposed to adding any sophisticated changes like automated rollup when homu doesn't even have proper testing (the CI just runs a style check).

r=me is [explicitly blacklisted](https://github.com/rust-lang/homu/blob/df43bc08201cd8140e043224ac5b9edecc3ed957/homu/main.py#L491) because it could also mean `r=me after you have fixed this and that`. I do not want to change that. We could add a different opt-in...

I think it's better just let homu recognize `rollup+`, `try+` and `treeclosed+`.

Sounds like #3 in the other direction. Perhaps disallow r+ when state is pending && try?

FYI we have implemented automatic relabeling in homu, and deployed to Rust with the following rules (rust-lang/rust-central-station#32): ```toml # Automatic relabeling [repo.rust.labels.approved] # after homu received `r+` remove = ['S-blocked',...

First we should record the SHA-256 + size of each file and `COUNT(*)` of each table somewhere. I suggest we *do not* reuse the `metadata` file, its format is not...