homu icon indicating copy to clipboard operation
homu copied to clipboard

Stop showing completed try builds

Open Mark-Simulacrum opened this issue 6 years ago • 5 comments

The UI for rust-lang/rust frequently fills up with numerous "success" at the top of the page.

There's sort of two bugs here. First, we don't currently keep whether a build is try or r+ in the DB, AFAICT, which means that these aren't displayed as success (try) after bors reboots.

The easy fix here is to just never show successful builds -- I'm not sure that they are important enough to be so prominent in the UI, since there's nothing that can really be done with them.

Mark-Simulacrum avatar May 18 '19 17:05 Mark-Simulacrum

Better just move them below the "approved" PRs instead of hiding.

kennytm avatar May 18 '19 20:05 kennytm

What purpose is there to showing completed builds? If there's not a concrete reason I disagree that we should move them rather than hiding them.

Mark-Simulacrum avatar May 18 '19 21:05 Mark-Simulacrum

The same reason we show PRs which have no status.

kennytm avatar May 19 '19 06:05 kennytm

Ah -- I guess I should clarify. I meant that the completed PR would have no additional label (i.e., be exactly the same as any not-yet r+-ed PR, both in terms of order and place in the list).

Mark-Simulacrum avatar May 19 '19 14:05 Mark-Simulacrum

Along the same lines, I wonder if stuffing failures way at the bottom is also counter-productive. If anything, those are PRs that are getting more attention, so they should be nearer the top than PRs that haven’t been reviewed at all.

bryanburgers avatar May 25 '19 00:05 bryanburgers