kennytm

Results 392 comments of kennytm

(Use flashback = SCN … for oracle snapshot)

we don't really need `ORDER BY _tidb_rowid` but we must support `WHERE xxx

We should already have run several dump checks against Mydumper but we have never collected any concrete data. Anyway the timing is similar or faster.

you can't write to a tar in parallel, so you still need an intermediate storage to store the incomplete files and write them to the tar.gz in a single thread.

@Rustin-Liu shouldn't the bot recognize that this entire repo belongs to SIG-Migrate? 😂

@sylzd hello, there hasn't been much updates since the pick up, do you need some help?

+1 but your "dry-run" code expected `copied` being a `PathBuf`, yet your proposed `add_extension()` returns a bool. I suppose the simplified code should be: ```rust let mut copied = doc.filepath.clone();...

> As in `From::::from(r)`? That would rely on type inference for the return type, barring some way to do `NonNull::from::(r)` or `r.into::()`. `NonNull::::from(r)`?

@jhpratt you could write `::from(r)` to absolutely use no inference.