Kenn Knowles
Kenn Knowles
I agree with your change to sickbay that Lifecycle test. It sounds like it is incorrectly specified, not taking into account allowable runner variation. Sorry for the delay which has...
I actually wonder if this could have weird issues? I guess the presumption of the prior code is that we are "caught up" if the next offset has caught up...
This whole thread of work is interesting. FWIW the whole point of `TypeDescriptor` is to carry the generic information. Otherwise we could just use Java's reflective capabilities. Is there a...
Is there any outstanding work on the protobuf major version bump?
R: @ahmedabu98
`@OnWindowExpiration` should not be called when there are any timers that could still fire. We have some limitations around this that are really bugs. But there is no sense to...
I'm going to close this as wontfix - this doesn't mean we won't address the underlying issue, which is needing a way to deal with looping timers in drain. I...
I set up at least the logicaltypes folder to have the analysis enabled in #35217. I did not want to create extra scope for your change, but I also think...
I haven't gotten to make another pass yet. I did just look at the tests and there is a prism failure which is pretty rare. I restarted the test job...
I think that the many cases of `@NonNull` and `@Nullable` applied to type variables indicates a problem. Each one really needs a comment justifying it, because it is unusual and...