Kenn Knowles

Results 148 comments of Kenn Knowles

I notice that the portable Spark runner sickbays tests that would probably catch this too: ``` excludeTestsMatching 'org.apache.beam.sdk.transforms.GroupByKeyTest$WindowTests' ```

This seems like a mostly-benign change. It is also fine to simply exclude the jar from the source release zip (I'm actually surprised if this is not already the case)....

I think they may be both serialized to the graph _and_ shipped in Kafka SDF using SerializableCoder (haven't checked). So, yes, this could be an issue.

Yea it is pretty hard to test. You would have to start a pipeline with the released version of the SDK and then use this version of the SDK to...

On your other PR I basically suggested what you did here. What was the issue?