Kenn Knowles

Results 148 comments of Kenn Knowles

I've dug around in the code enough that I feel OK making this change, if my understanding sounds right to you.

Actually I take this back. It seems that while this is based on the CF version, that version is pulled from the jar in some configurations which requires dependencies to...

Yea, I tried "remove the dependency from the configuration if CF version is 3.4.x or higher" but I got tangled in the control flow between `configureProject`, `applyToProject` and the callback...

I just worked around it in my project. We had a process that iterated over all configurations. I changed it to a specific list of configurations.

If I recall, I changed the `configurations` property of https://github.com/mdietrichstein/gradle-offline-dependencies-plugin I am doing the same thing now with another plugin.

You should worry less about compilation time in large projects. If a large project is recompiling everything, it is doing something wrong. We use CF in http://github.com/apache/beam which has more...

Actually I missed that `needJdk8Jar` is based on the checkerframework version and we are at 3.5.0 so it should be false. So this must be due to `needErrorProneJavac`.

+1 @narqo This should simply be generics. Promise is a type that is parameterized by another type. It is decades old, no need to invent things.

@phpnode Why not both? I'm completely fine with adding special tags to make common cases easy. But right now there's no underlying foundation to build the tag on, so I...