beam icon indicating copy to clipboard operation
beam copied to clipboard

Adds support for updating Schema state fields.

Open acrites opened this issue 6 months ago • 1 comments

On the Dataflow runner we already populate the encoding positions fields of the schema proto whenever the pipeline is updated with changes to the schema. This correctly updates any schemas used as inputs/outputs to DoFn's. For the portable runner, we don't update the schemas used by persistent state fields however. These just use whatever schema is compiled in.

So this PR factors out the code from the Dataflow runner that updates these schemas and reuses this code in the Java SDK.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

acrites avatar Jun 10 '25 20:06 acrites

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Jun 11 '25 00:06 github-actions[bot]

retriggering tests

scwhittle avatar Jun 17 '25 12:06 scwhittle

assign set of reviewers

acrites avatar Jul 30 '25 19:07 acrites

Assigning reviewers:

R: @kennknowles for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Jul 30 '25 19:07 github-actions[bot]

Reminder, please take a look at this pr: @kennknowles

github-actions[bot] avatar Aug 07 '25 12:08 github-actions[bot]

R: @ahmedabu98

kennknowles avatar Aug 07 '25 15:08 kennknowles

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

github-actions[bot] avatar Aug 07 '25 15:08 github-actions[bot]

Failing tests are not related

ahmedabu98 avatar Aug 10 '25 16:08 ahmedabu98