Kenn Knowles comments

Results 148 comments of


                                            Kenn Knowles

PulsarIOTest.testReadFromSimpleTopic is very flaky

I'm going to unassign this for now, then. Feel free to comment or grab it again.

Eliminate null errors from JdbcIO

Run Java_JDBC_IO_Direct PreCommit

Eliminate null errors from JdbcIO

The spotbugs failure does not reproduce for me locally so I will pull shenanigans to get the report from the jenkins box. We should probably find a way to at...

Eliminate null errors from JdbcIO

Run Java_JDBC_IO_Direct PreCommit

Eliminate null errors from JdbcIO

I don't know why spotbugs succeeded locally. There is a multi-statement try-with-resources that I had to annotate to ignore the warning. By grabbing the file off the Jenkins box it...

Initial prototype of using Beam transforms directly in a Flink pipeline.

Otherwise LGTM as far as getting this going. Very cool!

Initial prototype of using Beam transforms directly in a Flink pipeline.

There are still lots of nullness checks suppressed that presumably should be fixed, not suppressed. I didn't see any systemic reason to disable checking.

[Failing Test]: dataflow runner worker project test stuck causing Java PreCommit time out

Yea let's disable. This has caused weeks of delay for some major changes.

Remove unneeded View.asList when View.asIterable suffices.

Is this update compatible?

Remove unneeded View.asList when View.asIterable suffices.

Has this been superceded or still going to do this and guard it with the new option?