Keith Cirkel

Results 469 comments of Keith Cirkel

`depth` has yet to be implemented. PRs welcome!

Expanding the `CODEOWNERS` file to add an a11y team may help. Any handle or team listed in the `CODEOWNERS` file matching a file pattern will be requested as a reviewer...

> It gives developers freedom to implement the best solution for their given situation, rather than having to go with the one dreamed up by a standards group. FWIW the...

> Ok, but setting in stone a pattern that worked for GitHub in 2024 is problematic too. Yep I agree. I don't want us to design something here, I _want_...

I agree with everything @lukewarlow said. Seems trivial to add and has a nice value add. In whether or not it should traverse the flat tree, my vote is flat.

Please see https://github.com/openui/open-ui/pull/942 which goes into some detail around the security considerations of the proposal.

> Potentially as I'm not sure on changing boolean attribute to take values. I guess it was done with hidden so could be fine? Yes this is fine as it...

I think it is reasonable to make menus open on hover. Pointer devices are quite intentional for those who regularly use them, and having to click to affirm each action...

GitHub's repository action buttons have state. `Unwatch`/`Watch` and `Starred`/`Star` Similarly the issue subscription button which is `Subscribe`/`Unsubscribe`:

If I'm understanding the question, I think this is covered by the `loseinterest` event.