Keith Cirkel
Keith Cirkel
Is `searchParams` enumerable? I think a `URL` will land here: https://github.com/chaijs/deep-eql/blob/b8c99546f7a29d755d7e7e00c10b7a5f651fd15f/index.js#L416 and each key will be checked by getting the property, so I don't know why it would fail. Oh......
I'm on the fence about this, but regardless of those opinions, I would say this is probably a `feat` and I feel like its a `BREAKING CHANGE` as there is...
Thanks for the issue @karlitos. With the current API you can pass in a custom comparator function which gets called on every value so that you can filter it out...
@escKeyStroke you want that to return `true`? Sets are ordered, why would it return `true`?
This should be fixed then. I feel like we have had this discussion before but I'd challenge that sets should only equal with the same order. Can you give a...
Okay, I am enough convinced. However this may be derailing the original issue. Let's focus on fixing the original issue and hopefully fix the other ones alongside.
One of the issues we may have here to do with performance - is that IE11 has no way to iterate on sets other than `forEach`. We could use feature...
Thanks for the issue @m-nonna. PRs welcome!
Hey @xee5ch thanks for the issue! > Is it not more performant for large objects to just iterate over unsorted properties Great question! I don't know the answer to that....
Seems like this would be useful. How do you propose we make this change? We could `.slice()` the ArrayBuffers by the respective `byteOffset` and `byteLength` and compare the slices values?