Keith Cirkel

Results 469 comments of Keith Cirkel

[In the guide we mention calling `defineObservedAttributes`](https://github.github.io/catalyst/guide/attrs/#what-about-without-decorators). I notice your example doesn't do that. Does your example work when that is called?

Thanks for the detailed reply @kristoforsalmin! We can work to fix the breakage, such that existing code continues to work (after all that’s the semver contract!). We’re working on a...

ChakraCore issue https://github.com/Microsoft/ChakraCore/issues/5543

From my comment which links to 9 different in-the-wild implementations: https://github.com/js-choi/proposal-function-once/issues/4#issuecomment-1081984452 | name | returns original | subsequent returns? | |:---|:---:|:---:| | [`bit.js`](https://github.com/krasimir/bit.js/blob/master/src/03.once.js) | :heavy_check_mark: | `undefined` | [`aroma`](https://github.com/leafo/aroma/blob/511d6892e239e45163b2a7743fa8da290e726b38/nacl/js/aroma.coffee#L21-L27) |...

Some other implementations in the wild. I don't think any of these will cause problems with webcompat. - `bit.js`: https://github.com/krasimir/bit.js/blob/master/src/03.once.js - `aroma`: https://github.com/leafo/aroma/blob/511d6892e239e45163b2a7743fa8da290e726b38/nacl/js/aroma.coffee#L21-L27 - `@v4fire/functools`: https://github.com/V4Fire/Core/tree/master/src/core/functools (which also looks to...

> Also, maybe the html "types" should be included here as well, for ease of reference. @spectranaut shall I do that in this PR or a follow up?

Hey @TN1ck thanks for the issue. I'm not sure we should change this behaviour. I think it'd be better for you to change your assertion to only assert on the...

That error message sounds like it could indeed be useful. Do you fancy making a pull request to this effect?

Hey @hiredgunhouse thanks for the issue. I agree with this. It would indeed be great. Right now the docs are generated from the source code, you can see in the...

Supporting a "version introduced at" piece of meta is also possible - but we could add this as an annotation to the doc blocks in the code comments. It'd be...