Keith Cirkel

Results 485 comments of Keith Cirkel
trafficstars

PRs are always welcome, provided there is a motivating use case and the code is clean and well tested 👍

@EnixCoda I wouldn't worry about having it working exactly the same as the bug. Try to set up a reduced code example in something like a codesandbox, that exemplifies the...

Looks like the transpile step might be causing issues with the class name. You can add the following to see if it is a problem: ```js import {controller} from '@github/catalyst';...

What does your Vite configuration look like?

You could try removing Babel. esbuild should be able to transform any stage 4 features, as well as decorators and jsx, so Babel shouldn't be needed.

How do you feel about it abusing/violating the contract that `attributeChangedCallback` has? Also an added caveat ~~with 2 is that we're effectively _increasing_ the rate at which the callback is...

Thanks @blackgwe that's some great feedback!

Thanks for the report! This is very helpful, it looks like a bug. Would you like to submit a PR with a failing test case? That would be very helpful!

Thanks for the issue @onEXHovia! I think your idea has some merit, but I am not sure the prefix is totally redundant for custom elements. Custom Elements will inherit attributes...