Keith Cirkel

Results 469 comments of Keith Cirkel

Hey @Doogiemuc thanks for the issue. Thanks @C00bra for confirming Do either of you have the time to work on a PR fixing the documentation? Contributors get a permanent place...

Thanks for the PR @PiotrSliwa! I'll be honest, I'm not sure about this. How often do you need logic like this? Seems like something that can simply be done like...

You're making good points, all of them. Is this a reasonable PR? Sure. Will it save you time? Sure. Does it remove surface area from your code and put it...

Hey @Alloyed thanks for the issue! Would you like to make a PR bumping the version? I'll merge it and release it and we can look to update Chai too!

Hey @doasync thanks for the issue This, again, is because of the early `typeof` optimisation; `async () = >{}` and `function *() {}` are all `typeof x === "function"`, and...

> If we change this, we will break pretty common x.should.be.a("function") and y.should.respondTo("foo") usages. We could easily add a bit of extra code to chai to prevent breaking changes for...

I would argue that `type-detect`s role is really a fancy polyfill for `@@toStringTag`. Almost all of the code that isn't returning just `[Symbol.toStringTag]` is for performance or for conformance -...

This project is currently _on pause_ while the chai team update other chai parts. We hope to bring this plugin back up to speed around chai v5. It is dependant...

I believe the response object (`res`) should have the request object (`req`) attached to it: ```js app.get('/').then(res => res.req).then(req => expect(req.to.have.cookie('session_id'); ``` If someone would like to confirm this and...

@yipcma what are you expecting `res.req.body` to be? Do you have a reduced test case I could look at?