Keith Cirkel

What happens when you `curl` with a post to your server? Could it be a CORS issue or a redirect issue?

Hey @avronr thanks for this PR! @pravi is right. The travis yml has not been updated in quite a while, and all versions it currently tests in should be replaced...

Hey @AdamMcCormick thanks for the issue. It was removed as it was seen to be an anti pattern because it swaps out internal state which can cause issues in tests...

This looks like a great idea to me. @austince WDYT? @schrodervictor it'd be good to have `info` only check the keys present in the arg, e.g. if I omit the...

Please go ahead! I look forward to seeing the PR!

Hey @b123400 thanks for the issue. Firstly, currently, the way to do what you're hoping to do, is pass variables around: ``` js function fn(options) { options.foo = 1; }...

@b123400 hmm, actually you're right. All arguments are checked for deep equality. Apologies for the misinformation above. IMO this is wrong, as I demonstrated above it becomes a problem because...

@b123400 if you were to ask me to review the code, outside of a test context, then yes, I'd say you're mutating variables which is, IMO, a bad practice; functions...

@nickcarenza this is just a case of ensuring you can set up a test environment which determines what `conditional` is. If you cannot influence what it is, then again -...

It's been a while on this one, but I agree with your points. Personally I think we should wait a while for this one, but eventually do some breaking changes...