Keith Cirkel

Results 469 comments of Keith Cirkel

I think we could consider implementing something similar to `calledBefore` and `calledAfter`. Need a sensible way to implement it though, timestamps or some global variable would not be suitable, IMO.

> While I feel like this is a fine feature to add, I have a broader concern about this plugin. What is the long-term goal here? I personally have no...

@teone we still need to hash out some requirements before we discuss an implementation. It seems as though @henriksjostrom's original posting suggests they want to have some kind of global...

@meeber added. Are you not able to create labels?

@RubenVerborgh or @Tyderion: just curious - have you filed an issue within chai about this? I'm not exactly sure how we could solve it - but I'd certainly like to...

I think I might have an idea about fixing this though: Chai's `.property` changes the `flag(this, 'object')` to be the property you're asserting on - meaning if you do `expect({...

I'm happy to take a crack at a PR, I just wanted to gauge your opinion on it. So if you're happy I'll get working on it :smile:

Just an update - I've done some work on this, and progress is looking good. I'll put a PR up shortly. My main problem so far is that the `something`...

@RubenVerborgh I'd be happy to take over the project; I could pull it into the chaijs org, and make you a maintainer. The code would probably change quite significantly to...

Sweet, yeah simply transfer it to the chaijs org and I'll pick it up when I can