Kevin Anderson

It's worth fixing IMHO. We know our current implementation doesn't follow its reference, and we even have test cases to prove it. This function isn't used in pvlib's main SPA...

Closing since the PSM3 API no longer exists and we have removed the relevant functions.

In case folks missed it or have forgotten, there is useful and relevant discussion in #1403 of what `solar_zenith` should refer to. My read of that discussion was that there...

If this parameter name changes, we should consider doing it in combination with broader changes to that function (name and module, see #1350 and https://github.com/pvlib/pvlib-python/issues/1544#issuecomment-1358068972). PVWatts v5 doesn't account for...

Whatever change we make here, it would be nice (though not required, since we're just deprecating, not removing) to make it in the .0 release this week. > If we...

I think the full reference is Jaroslav Hofierka, Marcel Suri, The solar radiation model for Open source GIS: Implementation and applications. Proceedings of the Open source GIS - GRASS users...

A good guiding principle may be to use plural words only when multiple values are necessary. For example, I think `times` is an appropriate name for the `_get_sample_intervals(times, win_length)` function,...

> So tuple of float of length N only works with a PVSystem with N Arrays. Isn't that the intended behavior? Tuples for these inputs are supposed to index over...

> It would be simpler to describe behavior if we could state "tuples are distributed over Arrays". But that's not what happens when the system has only one Array: the...

> To be sure we're seeing the same thing, that code produces `ValueError: Length mismatch for per-array parameter` for `converter=tuple`. Correct? Correct. > And this is the case we want...