Kevin Anderson

Results 405 comments of Kevin Anderson

A couple suggestions: - `surface_azimuth`: remove "for example", as that could be interpreted as indicating that the user could choose another convention if they like. Also make clear that east...

The publish job now shows filesizes for the distribution files: ``` -rw-r--r-- 1 runner docker 28M Oct 22 20:59 dist/pvlib-0.11.2.dev21+g698a7cf-py3-none-any.whl -rw-r--r-- 1 runner docker 34M Oct 22 20:59 dist/pvlib-0.11.2.dev21+g698a7cf.tar.gz ```...

Seems like there are no objections here, so I will go ahead and merge. Thanks for the review @echedey-ls!

@RDaxini or @IoannisSifnaios, any interest in continuous integration (CI) infrastructure management? Adding python 3.13 to the test matrix would be a good way to dip your toes into that world...

It's a good question! The reason is that some of pvlib's dependencies are required while others are merely optional. "Required" means that `pip install pvlib` will fail if pip can't...

Yes a PR would certainly tell you whether the package landscape is sufficiently progressed for us to start using it for pvlib. I suppose there is no harm in opening...

The problem is that current and previous versions of pvlib _are_ in fact compatible with Python 3.13. That fact does not depend on whether PyPI makes it easy to install...

For once, my hesitation doesn't stem from any additional maintenance burden :P My understanding is that putting an upper bound on Python itself is not actually a solution to any...

> However, it sounds to me a bit like "It's been broken since the beginning, so don't fix it now." Just to be clear: my understanding is that this should...

> Perhaps this has something to do with the gregorian / julian date cutoff? It seems so. I reproduce the expected values exactly using this modified version of the function...