pvlib-python
pvlib-python copied to clipboard
Change g_poa_effective to effective_irradiance
- [x] Related to #1253
- [x] I am familiar with the contributing guidelines
- [x] Tests added
- [x] Adds description and name entries in the appropriate "what's new" file in
docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
). - [x] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
- [x] Pull request is nearly complete and ready for detailed review.
- [x] Maintainer: Appropriate GitHub Labels (including
remote-data
) and Milestone are assigned to the Pull Request and linked Issue.
g_poa_effective
is an alternative name for effective_irradiance
. The latter is the standard in pvlib (at least the most widely used).
This is a breaking change, but I don't see how this can be deprecated in a nice way.
The previous definition was also not correct. IMO it doesn't you can't use the term "broadband" about effective irradiance which has potentially been modified for spectral effects.
g_poa_effective;broadband plane of array effective irradiance.