Kevin Anderson

Results 405 comments of Kevin Anderson

> The coverage for the spa_c solar position method keeps failing even though it is covered in tests. Could that be caused by a dependency issue? Like the spa.c and...

@nicomt we're on the cusp of releasing 0.9.3, which includes your last PR. Do you agree that there is no problem making that release without including this PR? Since some...

> Thus to see refractive index reappear in the sky-integrated iam is, well, surprising. I assume this is in reference to FEDIS (#1562) rather than `schlick`. If I understand correctly,...

After much fussing, this is ready for review. Assuming the general thrust of this PR is accepted, is 0.10 too soon for the removal dates?

> For discussion: adding pvwattsv8_xxx, pvwattsv10_xx, etc. functions isn't appealing to me. Why not? If v10's xxx model is different from v8's I don't seen any reason not to implement...

PVWatts seems to be converging towards a "SAM Lite" with many of the same models, so this proliferation might be asymptotic, but point taken. My view: if the user wants...

> pvlib sounds pretty cool! Glad to hear you think so! I agree :) > Is there anything I shouldn't use pvlib for or that it can't do? Financial calculations,...

I think @cwhanse is suggesting keeping the input parameters as separate series but returning the outputs together in a single dataframe, which I agree is more consistent with other functions...

Thanks @bgpierc, is this PR ready for a close review? All the new code will need tests to verify that they execute without error, work with all the advertised types,...

> I added a test for the pvgis function, but I am unsure how to do one for iotools/cgiar.py. The DEM files are rather large (~70MB) so it may not...