Kevin Anderson

Results 405 comments of Kevin Anderson

@bgpierc I'm not sure what's going on with the three windows test failures, but it seems like some transient PyPI issue that isn't relevant to this PR, so OK to...

> For this function, the meta object would just be an empty dictionary. Well, the PVGIS API does actually return metadata, we just aren't doing anything with it right now....

[PVWatts v5](https://www.nrel.gov/docs/fy14osti/62641.pdf) and [SAM](https://www.nrel.gov/docs/fy18osti/67399.pdf) both have the option of a second snell & fresnel iteration for AR coatings, although I don't think either of them consider repeated internal reflections. I...

> Why was this not merged and being delayed to further versions are there any issues? I think I recall wanting to make some changes to the classification of "slow"...

Thanks @Jacc0027 for the effort here! I think I see how to get the tests working; would you mind if I pushed some commits to this PR for that? Then...

Looks like things are working! I think these are the last main things, @Jacc0027 can you take a look: - Fill in the two "TODO" parameter descriptions - Add an...

Hmm, for some reason this PR is not showing any changes to the `reference` and `whatsnew` pages: https://github.com/pvlib/pvlib-python/pull/1296/files Maybe you only changed them locally but did not include them in...

It would be better to include them in this PR so that all the changes are in one place. If you are editing them with Github online, then I think...

My understanding regarding flawed coefficients in the engerer2 decomposition model remains unchanged, but it seems that the TJ clear-sky model is obscure enough that I probably won't ever get the...

> I have written the code below to linearly interpolate using all available points, and therefore the resulting interpolation is not piecewise. This was done to match the Cassys implementation....