Justin Salamon

Results 132 comments of Justin Salamon

OK, cheers. This isn't high priority for me just yet, but will add to the stack.

> The cleanest way I can think of to solve this is to create a third class that wraps the Transformer and Combiner object - if there is 1 input...

I believe the current behavior is to document absolute paths (at the time there wasn't a use case for this feature other than documentation and completeness so I didn't think...

Yes, we can definitely look into this. At the same time, we're looking at more significant overhaul of the audio processing component in scaper to replace sox entirely, which could...

@pseeth will the current PR we're working on (#105) address this issue? I think so?

OK cool, shall we, as part of #105, get rid of this function altogether if we now can?

note: it looks like this should be possible if we switch to GH actions: https://github.com/features/actions

thanks @jtcramer for raising and thanks @pseeth for the great analysis! If the problem is in soundfile then indeed there's little we can do to actually address, but I agree...

I wonder if something more complete would be to scan the FG/BG library upon initialization of the scaper object, then issue a warning if there are files that aren't .wav...