Justin Salamon

[JOSS review] Docstrings missing information for output parameters

1

The docstrings are missing information about what the augmentation functions actually return. For example, the docs for fade_in_and_out say: ``` pydiogment.auga.fade_in_and_out(infile) Add a fade in and out effect to the...

code: ```python test_file = "liz.wav" apply_gain(test_file, +20) apply_gain(test_file, -20) ``` result: [gain_bug.zip](https://github.com/SuperKogito/pydiogment/files/4698798/gain_bug.zip)

Just tried `fade_in_and_out()` and got unexpected behavior. Here are my input/output files (the input is called input.wav): [fade_bug.zip](https://github.com/SuperKogito/pydiogment/files/4698792/fade_bug.zip) The input is a 2-second, 16-bit, mono, WAV file. The output is...

The README, docs, and docstrings don't specify which audio formats are supported. Please add information to all three about which audio formats are supported.

The installation instructions in the README and the [docs](https://pydiogment.readthedocs.io/en/latest/dependencies.html#installation) assume the user is using a linux OS that supports `apt install`, which isn't the case for windows and macOS. Please...

Use pysox to generate silence?

2

It seems like it's possible to [use sox to generate silence](http://billposer.org/Linguistics/Computation/SoxTutorial.html) using the `-n` flag for null input. Is it possible to do this with pysox right now? If not,...

Apply combiner to an input_filepath_list of length 1

2

Trying to combine a single file (which basically doesn't alter it unless the combiner applies transformations too): `cbn.build([filename], outfile, 'concatenate')` Raises an error: `ValueError: input_filepath_list must have at least 2...

Explicit control over sound event overlap

5

Certain scenarios require limiting the amount of overlapping sound events (or prohibiting it altogether). Right now there is no way to explicitly control for sound overlap. Proposed solution: add a...

High-level soundscape generators

15

Right now each event has to be explicitly added to the event specification (e.g. via for loop). It would be helpful to have high-level generators such that you'd only have...

Support changing soundscape duration on the fly

1

Under some scenarios the user might want to create soundscapes with different durations from the same scaper object. Right now this is not supported and the soundscape duration must be...