Justin Salamon

Results 132 comments of Justin Salamon

Based on offline discussion: * Update API in generate with `fix_clipping` and `peak_normalization`. By default these will be... `False`? We can check for clipping and raise a warning? It feels...

Yes, these are all sox warnings rather than scaper warnings. I forget whether it's possible to disable these, looks like it might not be supported yet based on the issues...

> Should we change the default of disable_sox_warnings from False to True? OK, I think we can change it. In this case we might want to add a line at...

Just revisited the code :) Per the docstring: > disable_sox_warnings : bool When True (default), warnings from the pysox module are suppressed unless their level is ``'CRITICAL'``. So, in principle,...

@turpaultn sorry finally getting to this. You can use the [jams library](https://github.com/marl/jams) to programmatically manipulate data in jams files (scaper uses the jams library internally precisely for this). I believe...

Thanks for clarifying your use case and for the example code. My concern here is that adding some value to an onset is just one possible operation someone might want...

That's really cool, nice! How about we follow the librosa model, and have a top-level folder (at the same level as the docs and tests folders) called "examples", and place...

Yes, agreed. This should also help prevent issues like #71. I'll add this to my stack.

The reason every distribution tuple is validated when an event is added is that it can be different each time. In your case you always add the same list of...