Justin M. Keyes
Justin M. Keyes
After comments are resolved this LGTM, we can merge it and keep improving it.
> let me know if we are all aligned with the return values for both `async` and `sync` modes. Might be a nitpick but I think the return behaviour when...
> loops of those Messages (>= 30/sec) Thanks, that's a very good hint. Looks like a `OptionSet` event is triggering a vscode-neovim handler, which then presumably tries to set the...
That seems like a good change to make on `check_options` and/or `set_options` (always pass it the "old" and "new" values). I also don't know if the debounce() stuff is really...
a solution was already proposed: https://github.com/vscode-neovim/vscode-neovim/issues/2267#issuecomment-2381694486 now waiting on someone to implement it. the extra reports aren't helping. > In VSCode, identical option settings do not trigger change events, so...
Sounds like this may be related to https://github.com/vscode-neovim/vscode-neovim/issues/2184
vscode-neovim 1.18.13 includes an attempted [fix](https://github.com/vscode-neovim/vscode-neovim/pull/2282) for this issue. Please restart vscode and confirm that you are running vscode-neovim 1.18.13 , then report here if there is any improvement. Thanks...
> when switch the focus from edit-tab to output-tab, I get tones of the log messages This may be a loop in the logger: updating the Output channel triggers something...
`vim.lsp.util` is a junk drawer, it's not intended to be a place where we add features. Based on the current patterns, I would expect `vim.lsp.buf.rename()`. But this issue needs more...
Would this not be covered by changing 'guifont' to be window-local? And then it's up to the UI to actually implement this behavior, which is out of Nvim's control.