Justin M. Keyes

Results 2414 comments of Justin M. Keyes

> If my PATH contains programs outside WSL, lspconfig is extremely slow. Thanks for debugging that! Likely caused by `exepath()` : https://github.com/neovim/nvim-lspconfig/blob/94dda50b2d9a29d0b76562a9027029538840e2d7/lua/lspconfig/configs.lua#L28-L31 or maybe there's an `executable()` call somewhere. (related:...

SGTM. Feel free to send a PR. The old lua/lspconfig/ configs are deprecated, but targeted bug fixes are fine. Will plan to tag a release before merging your change.

> I propose we revert the commit immediately and maybe edit the function so that it is executed **only** on Windows. I can send you a PR for that if...

The brackets indicate that -g is "optional". This is a common pseudo-syntax, but maybe it's confusing to use it here.

@ranjithshegde this would still be a welcome change, if you are keen

> those functions not only used in our repo. Where are they used? lspconfig was never intended to be a platform. It's intended to be data-only. And we need to...

We don't necessarily need to remove `lspconfig.util.root_pattern`, we can start by updating their implementations to use vim.fs and minimizing code where possible. And where possible, show a deprecation message that...

# Plan > what general strategy is for removing lspconfig functions we should keep the util stuff around to avoid breaking downstream. meanwhile, in this repo: - CI should fail...

The "Proposal" in the main description of this issue is updated and correct. To be clear: - we don't need to remove anything on `util`, its interface can stay frozen...