Justin M. Keyes

Results 2414 comments of Justin M. Keyes

Github itself shows a message about CONTRIBUTING.md to new contributors, so if they ignored that, I don't see how this will help. But we can try it

We can try it. Note: strongly opposed to "checklist" templates which many projects have. Those are just noise.

> behind a company proxy / firewall, where PyPI cannot be directly reached We may need to think about a more general mechanism for proxy support. Especially after https://github.com/neovim/neovim/issues/23232 Adding...

> The URL is unreachable because of firewall settings and therefore can be considered a semi-broken state. It's completely fine if a healthcheck is broken in weird environments, until we...

The door is open for anyone that wants to change the healthcheck to use pypi/uv whatever to check for the latest version instead of making a HTTP request. Don't need...

@Vinschers please send a PR, ideally with a test.

> Let's please keep simple download and full requests separate. Why are they separate? What is `vim.net.download()` doing that requires it to be separate from `fetch()` ?

> Nothing. `fetch == download` (PR you just closed), as opposed to full `GET`/`POST` requests needed for _editing_ over the network (this PR). I am asking why we need anything...

> not having to wrangle request parameters for simply downloading a spell file is worth a (simple) convenience function. But it doesn't need to be a separate function. And the...

@tampueroc to unblock you, my suggestion is - Continue with 1 PR for the low-level `request()`, and let's see what it actually looks like. - Do not attempt to support...