Justin M. Keyes

https://github.com/neovim/nvim-lspconfig/pull/3734 fixes this for Nvim 0.11.2+

patch to demo the issue, from https://github.com/neovim/node-client/pull/418 ```diff diff --git a/packages/neovim/src/attach/attach.test.ts b/packages/neovim/src/attach/attach.test.ts index 70d16597..4f0c6942 100644 --- a/packages/neovim/src/attach/attach.test.ts +++ b/packages/neovim/src/attach/attach.test.ts @@ -154,14 +154,38 @@ describe('Nvim API', () => { expect(newLines).toEqual(['line1', 'line2']);...

any issue that is still open is up for contribution.

> @justinmk Mocha doesn't support coverage out of box, Do u think https://github.com/istanbuljs/nyc is a good choice for us? nyc is deprecated, https://github.com/bcoe/c8 is the current best option AFAIK.

> C8 requires node >= 18, wtf? We could skip codecov for older node.

maybe drop `--parallel` for now? not sure if these tests are prepared for that.

that's weird, but based on https://github.com/mochajs/mocha/issues/185 seems like mocha intentionally does not set NODE_ENV? For now we could just add to testSetup.ts: process.env.NODE_ENV = 'test';

might need a `.c8rc.json` in packages/neovim/. IIRC the "lcov" reporter was important to get it to work with codecov. example (untested, just a sample): ``` { "report-dir": "../../coverage/neovim", "reporter": ["lcov"],...

> replace jest-mock with sinon On second thought, let's keep jest-mock for now. Mocking should be rare, and unless sinon improves something, using jest-mock avoids churn and doesn't really hurt....

`## Problem` / `## Solution` headers might be useful. Though that has a problem: the headers typically must be deleted, since the commit message already should have Problem/Solution. Which indirectly...