Justin M. Keyes comments

Results 2414 comments of


                                            Justin M. Keyes

shrink `util` implementation by using upstream functions, avoid `util` in configs

# Status related work: - https://github.com/neovim/nvim-lspconfig/pull/3450

shrink `util` implementation by using upstream functions, avoid `util` in configs

There was no previous deprecation strategy for nvim-lspconfig. The goal is to shrink nvim-lspconfig in order to make progress towards upstreaming it, while minimizing damage to user trust. Which part...

shrink `util` implementation by using upstream functions, avoid `util` in configs

Ok I see what you mean from the discussion in https://github.com/neovim/nvim-lspconfig/pull/3460

shrink `util` implementation by using upstream functions, avoid `util` in configs

https://github.com/neovim/nvim-lspconfig/pull/3460 is a good example of why removing `util.dirname` gains almost nothing. Keeping the skeleton around is low cost. Because we'll just freeze it once everything is upstreamed. And meanwhile,...

shrink `util` implementation by using upstream functions, avoid `util` in configs

Only thing remaining is `root_pattern` , `insert_package_json`, and `strip_archive_subpath` https://github.com/neovim/nvim-lspconfig/issues/3768

plugin lifecycle: dispose() resources, handlers, ... (WAS: "Isolated environment for plugins")

> VSCode provided a reload functionality without reboot editor. That reloads the vscode "extension host". Nvim has [remote plugins](https://neovim.io/doc/user/remote_plugin.html), which run as co-processes. But in both vscode and Nvim, plugins...

LSP completion: display documentation if exists for an item

> I found some bugs with `vim.api.nvim__complete_set`, but since it was demoted to an experimental API in [fix(api): mark nvim__complete_set as experimental #28579](https://github.com/neovim/neovim/pull/28579) I would like feedback as to whether...

refactor(treesitter)!: remove "all" option of Query:iter_matches

@gpanders @clason are we ready to move forward with this or need more time ?

feat(lsp): add vim.lsp.config

> towards a system which emphasizes multi-server setups front and center (projects) ... Projects should be multiroot, @mjlbach this is a great callout. As a low-risk step, any objection to...

feat(lsp): add vim.lsp.config

> I would keep it as a higher level utility function generically for running callbacks on path traversal, rather than having any harcoded string based method Perfect, totally agree.