Julien Wajsberg

Results 508 comments of Julien Wajsberg

The inverted view orders by the self time, the functions view orders by the running time. Thanks for the heads-up, I'll put that in our internal backlog

@jandem @mstange would cleaning up the work linked in https://github.com/firefox-devtools/profiler/issues/15#issuecomment-589682581 be good enough as a first step? (see #2388 for the list of left-over tasks). ![image](https://user-images.githubusercontent.com/454175/109633679-a6b9fa80-7b48-11eb-84e0-f4790580d790.png) I feel like it...

The solution for this issue isn't clear, but #4157 would make a lot of things possible.

> It would be nice if the profile format structurally reflected the fact that there were no samples `samples` could be `null` instead of being zero-length? It would be interesting...

I wonder if thisis still needed now that we can search the marker chart from an input field? thoughts @mstange @gregtatum @fqueze ?

Yes we're using IDB for some things and this doesn't work in private browsing. I believe it could be made to work in this mode but we haven't invested time...

Hey @canova, this is now ready for review! (again :-) )

https://github.com/sindresorhus/type-fest could be a useful typescript-related project with utility types. Especially their `Merge` utility type can be slightly more correct than the intersection to replace the spread operator (where the...