Julien Wajsberg

Results 512 comments of Julien Wajsberg

I won't be able to guide you really, but you can start by looking at https://github.com/firefox-devtools/profiler/blob/main/CONTRIBUTING.md. Thanks

Yeah I believe this is it. If you want some more feedback, the easiest would be to open a pull request, that will automatically build a deploy preview that we...

Interesting! Strangely I don't see an obvious difference in the code paths for these 2 cases, so if you can provide a URL where you see the problem so that...

Oh I see! When getting a profile from an URL we enforce that it must be a JSON in: https://github.com/firefox-devtools/profiler/blob/2214df8a1b10f434476e963ae40bdb9e15f67b0e/src/actions/receive-profile.js#L1282 And only after that we pass it to the function...

> Hello. I want to work on this issue if it is still open? Hey @barisconur, this issue is not trivial (our profile loading mechanism is quite complex -- possibly...

I'm gonna reopen this issue just for the sake of tracking this. Maybe well have to discuss of the approach again.

I believe this is related to https://github.com/firefox-devtools/profiler/issues/2783

I disabled ublock origin, and then the website worked. So this is more likely a problem with ublock origin blocking something that the website relies on.

Ceci dit j'ai l'impression que les gens aiment bien ce comportement: on a le créneau préréservé mais il faut quand même valider. Ça les rassure plutôt que d'aller jusqu'au bout...