profiler
profiler copied to clipboard
In the marker chart, the marker names can not be selected, copied, or searched for using the find bar
It would be great to make the marker names real HTML text instead of drawing them in canvas.
This has been requested by fqueze.
┆Issue is synchronized with this Jira Task
Yes, the names drawn by canvas was a hack for the initial prototype, and we haven't invested time to make markers better. This would be great, as well as placing them on the whitespace on the left hand side that currently has the thread name. That layout is leftover from when we had multiple threads in the view at the same time.
I wonder if thisis still needed now that we can search the marker chart from an input field? thoughts @mstange @gregtatum @fqueze ?
The 2 use cases I had for wanting to select marker names were:
- using the findbar to find a marker quickly. This is case is indeed well covered by the new "Filter Markers" input field.
- selecting a marker name to search it in searchfox to figure out which code generates it.
So I would still like to be able to select markers for the second case. But it's probably lower priority now than it used to be.
selecting a marker name to search it in searchfox to figure out which code generates it.
Is this something the sidebar would solve?
This and/or having "copy marker name" in a context menu
selecting a marker name to search it in searchfox to figure out which code generates it.
Is this something the sidebar would solve?
Hopefully it will, yes. Unless we show the sidebar by default, this may remain less discoverable than simply double clicking to select and then Cmd+C to copy... but this is also a niche use case, so maybe it's fine.
Hopefully it will, yes. Unless we show the sidebar by default, this may remain less discoverable than simply double clicking to select and then Cmd+C to copy... but this is also a niche use case, so maybe it's fine.
I was just thinking as the sidebar seems less work, this could solve the issue. The context menu could also be a good idea, especially until we enable the sidebar by default.
#4157 would solve this.