Jesper Sandvig Mariegaard
Jesper Sandvig Mariegaard
I would suggest to make one release before merging this
I guess we can close this @ecomodeller ?
I guess it is not possible to use _point_in_polygon() ?
> But the subset has lost the reference to the original model domain. > > Does the concept of `outline` of the model domain still apply for a subset? I...
@ecomodeller is this still relevant after the notebooks added by @jpalm3r ? Or should we close this PR?
Okay to close this @ecomodeller ?
I guess this works for small dfs2 files - but dfs2 files can often be huge (e.g. global meteorological data). I am not sure if it is better to merge...
> @jsmariegaard Isn't this good enough to start with? > > We are not in able to perform proper spatial subsetting in dfs2 anyway, so the only part we could...
`temporal_coverage` can also be useful for this assessment https://dhi.github.io/modelskill/user-guide/plotting.html#temporal-coverage
Is the point inside the domain? (it could be that the error message could be improved in this case)