Basic Support for Dfs2 in GridmodelResult
Basic in the sense, that the entire file is read, no support for subsetting.
I guess this works for small dfs2 files - but dfs2 files can often be huge (e.g. global meteorological data). I am not sure if it is better to merge this and then we would at least have some support for dfs2 files or we should make the right implementation of track and point extraction in MIKE IO instead. 🤔
@jsmariegaard Isn't this good enough to start with?
We are not in able to perform proper spatial subsetting in dfs2 anyway, so the only part we could optimize is the temporal subsetting, which we could delay by moving it to the extract, which only would make sense if we supplied the entire list of observation, instead of one observation at a time.😒 (would have to do the same for dfsu).
Discussed in https://github.com/DHI/modelskill/discussions/123
@jsmariegaard Isn't this good enough to start with?
We are not in able to perform proper spatial subsetting in dfs2 anyway, so the only part we could optimize is the temporal subsetting, which we could delay by moving it to the
extract, which only would make sense if we supplied the entire list of observation, instead of one observation at a time.😒 (would have to do the same for dfsu).
Let's do it :shipit: