modelskill icon indicating copy to clipboard operation
modelskill copied to clipboard

Basic Support for Dfs2 in GridmodelResult

Open ecomodeller opened this issue 1 year ago • 1 comments

Basic in the sense, that the entire file is read, no support for subsetting.

ecomodeller avatar Mar 17 '24 08:03 ecomodeller

I guess this works for small dfs2 files - but dfs2 files can often be huge (e.g. global meteorological data). I am not sure if it is better to merge this and then we would at least have some support for dfs2 files or we should make the right implementation of track and point extraction in MIKE IO instead. 🤔

jsmariegaard avatar Sep 20 '24 11:09 jsmariegaard

@jsmariegaard Isn't this good enough to start with?

We are not in able to perform proper spatial subsetting in dfs2 anyway, so the only part we could optimize is the temporal subsetting, which we could delay by moving it to the extract, which only would make sense if we supplied the entire list of observation, instead of one observation at a time.😒 (would have to do the same for dfsu).

ecomodeller avatar Nov 12 '24 19:11 ecomodeller

Discussed in https://github.com/DHI/modelskill/discussions/123

ecomodeller avatar Nov 12 '24 19:11 ecomodeller

@jsmariegaard Isn't this good enough to start with?

We are not in able to perform proper spatial subsetting in dfs2 anyway, so the only part we could optimize is the temporal subsetting, which we could delay by moving it to the extract, which only would make sense if we supplied the entire list of observation, instead of one observation at a time.😒 (would have to do the same for dfsu).

Let's do it :shipit:

jsmariegaard avatar Nov 13 '24 07:11 jsmariegaard