Jesper Sandvig Mariegaard comments

Results 73 comments of


                                            Jesper Sandvig Mariegaard

Problems with match() (flooding/drying)

Thanks. Could you share the code you use for the comparison as well as the full stack trace of the error?

Problems with match() (flooding/drying)

Thanks for reporting back @ducvi ! Yes it would be a good idea if modelskill provided a better error message in this case.

Scale data in Comparer

I wonder if this should rather be a `transform_values` function that could also be used for e.g. log transforming values cmp.transform_values(func=lambda x: np.log(x), new_quantity = ms.Quantity("log concentration", "-")

DFSU.read() very slow on AMD CPU or linux

@JesperGr - this most be related to MIKE Core ...

DFSU.read() very slow on AMD CPU or linux

@bhlevca could you try with a profiler - I hear Scalene is great https://github.com/plasma-umass/scalene :-)

DFSU.read() very slow on AMD CPU or linux

You get those when you install MIKE IO (pure python)

DFSU.read() very slow on AMD CPU or linux

@JesperGr do you know anything about read speed of dfsu files on AMD using MIKE Core?

match() should not fail when a comparison is empty

Solve by adding action_no_data argument on match() which accepts "ignore", "warn", "error"

Timeseries plot style

closes #463

Timeseries plot style

Yes, either @ecomodeller or I will merge after review. Thanks