Fix GeometryFM.contains (optional use of shapely)

[ecomodeller]

[jsmariegaard]

I guess it is not possible to use _point_in_polygon() ?

[ecomodeller]

I guess it is not possible to use _point_in_polygon() ?

I suppose we can, but that is only part of the solution, we still need to construct a proper polygon with holes for the entire domain, unless we loop over all elements, which we could do in a clever way similar to how find_index works (when #685 has been fixed) .

[ecomodeller]

@jsmariegaard ...plot.outline() is used to plot the outline of the model domain. Very useful!

We have the ability to extract elements into a new file, e.g.

But the subset has lost the reference to the original model domain.

Does the concept of outline of the model domain still apply for a subset?

[jsmariegaard]

But the subset has lost the reference to the original model domain.

Does the concept of outline of the model domain still apply for a subset?

I guess it does not in many cases. But the user would probably know that and could accept that the plot.outline() would be empty or raise an error 🤔