Joyee Cheung

CI is finally green...can I get some re-review please? @jasnell @benjamingr @aduh95

If we want to be aligned with npmrc, https://www.npmjs.com/package/ini can be an option too (there are other native INI parsers too, like https://github.com/benhoyt/inih) > and it should support all of...

I think making this opt-in would bring us back to square one, especially if the surface is limited to a flat list, then it’s not really too different than .env;...

> this has the benefit of automatically being inherited into child processes whenever env is passed down. I think this is actually a flaw, not a benefit, because a flat...

> A nodejs section in package.json is ideal. Make it so that if it's a string, then that's the name of a file to load, like many other tools do....

> Users already have ways to exert granular control of what flags and/or environment variables are passed into child processes or workers, via execArgv or env. The word "user" is...

> Since Node.js - in contrast to something like ESLint - can serve multiple purposes within a single project, only being able to supply a single config that has to...

Actually going back to OP I wonder if we should just support preloaded JavaScript files specified in package.json, because a declaration-based config can always be very limited (that’s why people...

> JavaScript files wouldn't be editable by other tools, for example to register hooks. If we go with the simplest APIs in the OP: ```json { "preload": [ "apm-package/register" ],...

Fixed the misplaced DCHECK