Results 716 comments of Joyee Cheung

> But then what about a require(esm) or a import(cjs) - would these have both a cjsModule and an esModule context value? Or would the wrapper dynamically adjust on either...

> so long as the design does not incorporate support for source text module. The design does incorporate support for source text modules, for example, this would be possible: ```js...

> 2) is currently not spec compatible due to it breaking spec execution invariants. I am not sure if you have read the comments, but it's spec-complaint - when imported...

> The problem here is a.mjs importing b.mjs where we currently only run the hook for a.mjs's CJS wrapper module and not the native a.mjs or b.mjs at all. If...

> I suggested a rename so this can land immediately and then we can follow up with discussions. I would prefer landing it with an intuitive name instead of landing...

> Did you try vcbuild.bat noprojgen? I tried running with `noprojgen` in a project that has not been changed and it still did a bunch of building and took ~8...

cc @nodejs/platform-windows @nodejs/build

I am running into the slowness issue again. @targos @StefanStojanovic do you mind reviewing the changes? If it's not supported to add it into the docs I am happy to...

This seems to fix https://github.com/nodejs/node/issues/54918 - I started two stress test jobs before opening this PR: - With just the test changes that reverted the workarounds: https://ci.nodejs.org/job/node-stress-single-test/565/ ❌ - With...

I tested this with https://github.com/nodejs/node/pull/58070 which is also seeing a deadlock in the heapdump tests. The good news is that this is suffice to fix the deadlock by default. The...