Joyee Cheung
Joyee Cheung
Blocked on https://chromium-review.googlesource.com/c/v8/v8/+/5403888 (and maybe https://chromium-review.googlesource.com/c/v8/v8/+/5447348 too)
https://chromium-review.googlesource.com/c/v8/v8/+/5403888 has landed but given that the upstream has [deprecated the current wrapper descriptor-based integration](https://groups.google.com/g/v8-dev/c/Q71L-BngFgk) and the new API requires a series of V8 changes to upgrade to, I think...
Rebased after v8 upgrade landed. New benchmark numbers: ``` ❯ node-benchmark-compare script.csv confidence improvement accuracy (*) (**) (***) vm/compile-script-in-isolate-cache.js n=1000 filename='test/fixtures/snapshot/typescript.js' type='with-dynamic-import-callback' 0.37 % ±0.51% ±0.69% ±0.91% vm/compile-script-in-isolate-cache.js n=1000 filename='test/fixtures/snapshot/typescript.js'...
cc @nodejs/cpp-reviewers @mcollina @legendecas
The heap snapshot tests need to be updated since now we don't have a global list of them under `Node / Environment` (which is kind of the point) . It's...
Updated the test with a fixture modified from https://chromium.googlesource.com/v8/v8/+/b00e995fb212737802810384ba2b868d0d92f7e5/test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc#134 (I personally find it a lot easier to debug than the `validateSnapshotNodes()` helper that has been used to verify `BaseObject`s. Maybe...
Fixed the linter complaints..
It seems the new hash function supporting v8::Data for JSGraphNode doesn't work well with std::unordered_set in MSVC, but then we don't need to implement it if we use a std::set...
This will need some patching to work on older versions of V8, applying the dont-land labels for now.
Fixed the tmpdir test (should be checking what's in `$tmpdir/node-compile-cache`, not `$tmpdir` directly)