Results 710 comments of Joyee Cheung

cc @nodejs/cpp-reviewers @nodejs/startup

In this case I think it might still be okay to wait for maybe a week to confirm that this still reproduces on v20.3.0. But in retrospect I think we...

If we still have bugs that are pending a fix, I think the best thing to do is have a release ASAP that turns it off by default again. The...

It's almost constantly failing now, perhaps we should just skip it on Windows until it's properly fixed to at least give the CI some green space..

We don't support udp and the test module in the snapshot yet.

Rebased using the new SnapshotBuilder::Generate() overload added in https://github.com/nodejs/node/pull/48242 and added a test. Will add more doc and tests next week but the implementation is there.

> What's the difference between snapshot and code cache (bytenode)? If you have a bunch of top level code with a bunch of inner functions, usually when building the snapshot...

CI is almost green (with some flakes that look irrelevant). Can I have some reviews please? @nodejs/single-executable thanks!

> So, if I understood it correctly, a snapshoot is a combo of a module compiled and bytecode functions plus heap after executing the module top level code, while the...

> Could it of our interest when generating the snapshots, so no Javascript code is included in it? I would say that's not always a win, you could also have...