node icon indicating copy to clipboard operation
node copied to clipboard

test: make IsolateData per-isolate in cctest

Open joyeecheung opened this issue 1 year ago • 1 comments

This ensures that we only create one IsolateData for each isolate inthe cctest, since IsolateData are meant to be per-isolate. We need to make the isolate and isolate_data static in the test fixtures as a result, similar to how the event loops and array buffer allocators are managed in the NodeZeroIsolateTestFixture but it is fine because gtest ensures that the Setup() and TearDown() of the fixtures are always run in order and would never overlap in one process.

joyeecheung avatar Jun 13 '23 18:06 joyeecheung

cc @nodejs/cpp-reviewers @nodejs/startup

joyeecheung avatar Jun 19 '23 12:06 joyeecheung

CI: https://ci.nodejs.org/job/node-test-pull-request/52444/

nodejs-github-bot avatar Jun 25 '23 03:06 nodejs-github-bot

Landed in 42d8143ce5baf5153a7a8d1bffa077209558a15d

nodejs-github-bot avatar Jun 25 '23 05:06 nodejs-github-bot