Joyee Cheung
Joyee Cheung
Backing it out from https://github.com/nodejs/node/pull/56927 to avoid introducing surface for regressions.
Hi, is the original issue still relevant? I was in the process of backporting https://github.com/nodejs/node/pull/52135 which seems to have caused some regressions and it seems this is fixing one of...
There is https://github.com/nodejs/node/pull/50590 which has stalled for some time
Opened https://github.com/nodejs/node/pull/55604 for 1, since I think it's a handy flag on its own (and for 2 or 3 we'll also need some changes already in there to track the...
I was implementing `getAccessedEnvironment()` and it feels like a utility that's useful beyond just snapshots. It seems useful to have: ```js process.accessedEnv.record(true); // Do things.. process.accessedEnv.get(); // Returns a set...
> How would you recommend getting the set of environment variables read by Node internals during the snapshot creation, such as NODE_V8_COVERAGE? I think we can support a configuration in...
Maybe for a more dedicated API it's better to have a global record & local ones (e.g. for tests), so it can be something like: ```js process.traceEnv.global.start(); // can also...
Working on a prototype of the global tracing store here https://github.com/joyeecheung/node/tree/snapshot-env-api
This has caused 9 PR to fail out of the last 100 CI runs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-17.md We should consider marking it as flaky unless someone is invested in fixing it. cc...
Actually this test should be split up before being marked as flaky. It's one of those tests that squeezed tons of test cases in one file (sigh) and marking it...