joshieDo
joshieDo
Couple questions... > however, the gas returned by the executor is the exact gas value the call consumed, which might not be enough if used as gas_limit But that's why...
https://github.com/mattsse/foundry/blob/dfb51e96c43617ebb7de12d11bf06561d775bd95/cli/src/cmd/forge/script/runner.rs#L160-L165 And we probably need the same logic here
> does deploy, commit? we can definitely add estimation there as well. yeah, but it might be trickier, since there's no `deploy_raw` ?
It will still take some time for etherscan to add it from my understanding. And when it does arrive, some of these changes will need to happen anyway.(eg. passing sourcemaps...
i'd love to have this feature, but with all the refactors/conflicts (also the incoming TUI one), it's probably better to start from scratch. Maybe use this one as a potential...
> Is there any chance we're not bumping the nonce in the Create hooks in the EVM broadcast (whereas we do it correctly in the Call hooks)? Doubt it... Unless...
I did some digging into it, and I tried out your network, and I had the same error. How modified is this forked chain? I cannot get a transaction confirmation...
looking further, the RPC doesn't seem to be returning certain fields, which ether-rs requires on `eth_getTransactionByHash` (@mattsse ). i'm not sure about what's standard though. ```{ err: Error("missing field `v`",...
this is from the forked chain, and it can actually be reproduced with `cast tx` ``` cast tx 0x1dbaec62a306d71fd0b2359fd5b057a980e9ede58d06867ac19596447509cb99 --rpc-url "https://staging-v2.skalenodes.com/v1/whispering-turais" ```
skalenetwork is not returning all the fields it **should** on `eth_getTransactionByHash`. If you can get them to do that (issue/pr), then `--slow` would work. `Invalid Nonce` leads to me believe...