joshieDo

Results 81 comments of joshieDo

About the original bug, is this just a simplification of what you've hit in another project? About this specific case, this seems like an optimization made by the compiler, leading...

Should we make the forge's default CREATE2 deployer, the default address for `--deployer` ? I think it makes sense

The way we verify contracts or create the transaction depends on the factory we use. So just letting anyone use their own factory implementation is not that straightforward imo. So......

> Afaik Etherscan keys are universal, so a key from mainnet also works on Rinkeby? In that scenario sure. But avalance != eth != polygon > Otherwise I lean more...

lgtm, given the conflict fix sorry was sick and my github notifications are a mess.

you can still manually set the sender with `--sender ADDRESS` I'm still thinking about the best way to check for the presence of `one` wallet in the beginning of the...

No, no I don't. You can have all that, given that you have the addresses of each path. If you want to explicitly specify an account which would be the...

> 0x3fAB184622Dc19b6109349B94811493BF2a45362 Does it still have issues with the latest version? Current master branch should handle that https://github.com/foundry-rs/foundry/blob/f0fa5da3c53858dbf9ac602ffeb633e15c39b9a3/evm/src/executor/mod.rs#L108-L120

Which network? Do you actually see it deployed on the etherscan in question ?

If you call again (once you see it on etherscan) without the `--broadcast` flag, and only with the `--verify`, does it still happen ? I noticed that Goerli etherscan can...