joshieDo
joshieDo
Yes it is, there are still some places where it can be used (eg. hashing storage stage)
works, although a bit ugly: ```bash ./target/maxperf/reth db --datadir holesky get mdbx StorageChangeSets "[0,\"0x4242424242424242424242424242424242424242\"]" 0x0000000000000000000000000000000000000000000000000000000000000024 (...) 2024-07-12T10:32:37.347357Z INFO Verifying storage consistency. { "key": "0x0000000000000000000000000000000000000000000000000000000000000024", "value": "0x0" } ``` ```bash ./target/maxperf/reth...
Bad CI! ``` Failed tests: [FAIL. Counterexample: calldata=0x94a508f10000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000, args=[true, true, false, true, true, [false]]] testMultiProofVerifyEmpty(bool,bool,bool,bool,bool,bool[]) (runs: 1513, μ: 36734, ~: 37585) ```
Saw it linked and wanted to give my take. > but there are many logical branches that can only reach when another function has been called with another parameter. Is...
should be fixed when https://github.com/paradigmxyz/reth/pull/8143 gets merged
thank you @guha-rahul!
looks real good overall! i guess this can be an opinated topic, with no right or wrong way, so I'll just leave my opinion. * **Scenarios should have as little...
> I generally prefer explicit coding over obscuring details just to avoid duplicating logic I feel like there must be nuance here. Any abstraction is obscuring details by default. However,...
That specific error log is expected and part of the e2e test @Rjected ~~so I'm thinking it's really about the long duration of the test (20s if i recall)~~ unsure...
This was the only mention of this issue I've seen. Feel free to reopen if it happens again