joshieDo

Results 81 comments of joshieDo

in general you can (thats how transaction expiration works), unsure about the headers specifically since there might be some assumptions that headers are never pruned (eg. genesis block)

we might want to try this one with `lz4` https://github.com/paradigmxyz/reth/blob/f0c0b3db4e47c167244654a5f03e5e388c9505fe/crates/storage/provider/src/providers/static_file/writer.rs#L833-L837

not merging yet, want to add additional tests for filedatareader after all

Imo, I don't think they should move to codecs. They're inherently db-traits which can be fulfilled by codec(s). maybe another crate db-serialization or smth like that?

reth-codecs in my view is for actual codecs and their impl. `Compact` is the only one there, but it could have others(as it had in the past) bincode, etc. these...

Forgot, testing today!

might be wrong but this feels unsafe when it touches in-memory ranges. every query to `self.canonical_in_memory_state.get/fetch/state` should be viewed as a `DatabaseTransaction` in which the view might change in the...

Nice! Do you have any numbers on the speedup ? (eg. https://reth.rs/run/sync-op-mainnet.html#minimal-bootstrap-recommended)

On a closer look, this might not be that straightforward after all. `StaticFileProvider` never expected having to concurrently manage different writers for the same segment, and so, only keeps one...