Josh Black
Josh Black
Something that is a little confusing for `ActionMenu` in this scenario is that it has `role="menu"` semantics, so descendants should only be of `role="menuitem"`, `role="menuitemradio"`, or `role="menuitemcheckbox"` (or a group...
Just a quick update on this, have an interim fix over at: https://github.com/primer/react/pull/2468 However, it seems like the ideal here is to avoid using `ActionMenu` due to `role="menu"` semantics. Due...
Just wanted to follow-up on this PR after some of the discussions on Slack today to see if we're aligned on next steps 👀 It seems like there might be...
Hey @koddsson! 👋 Wanted to follow-up on this real quick 👀 It seems like this kind of change will need to be slated to the next major release (v36) and...
bump @aagonzales when you get a sec!
cc @laurenmrice do you know who would be good to direct this towards on brand?
@janhassel I think in terms of stroke width this got adjusted by defaulting to larger sizes of pictograms. Unfortunately, at smaller sizes, it seems like something that will not be...
@janhassel definitely a great point, I'll defer to @dudley-ibm who is authoring the pictograms to see what he thinks 👀 I think the current stroke guidance currently comes from the...
Looking great! 🥳 Thanks so much for taking this on 🙏 Just wanted to leave some notes/questions on behavior since I wasn't sure what was expected 1. SC seems to...
@japf just pushed up a small change for that styled components issue! Let me know what you think, also happy to make a PR for this kind of stuff in...